Null values support added #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added integration and parser tests for nil Hacked JS server to return null
|
While null is a non-standard extension I like the client to be as tolerant as possible. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend Framework's XML-RPC service gives XML that couldn't be parsed correctly:
<?xml version="1.0" encoding="UTF-8"?> <methodCall> <methodName>system.echoNull</methodName> <params> <param> <value> <nil/> </value> </param> </params> </methodCall>My commit adds support for
<nil/>'s enclosed in<value/>. Also this required a hack in the JS server. Currently node-xmlrpc's parser doesn't support nil too.