Skip to content

Commit

Permalink
upgrade release.yml to upload-artifact@v4 (#1410)
Browse files Browse the repository at this point in the history
Github has deprecated `v1` and `v2` of `actions/upload-artifact` which
causes occassional CI failures and will affect our ability to make new
releases in the future. This PR updates the version used in
`release.yml`.
  • Loading branch information
Vighnesh-V authored Sep 13, 2024
1 parent b765d7b commit cd1803e
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,18 @@ jobs:
run: cmake . -DCMAKE_BUILD_TYPE=Release
- name: build
run: cmake --build . --target Luau.Repl.CLI Luau.Analyze.CLI Luau.Compile.CLI --config Release -j 2
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: matrix.os.name != 'windows'
with:
name: luau-${{matrix.os.name}}
path: luau*
- uses: actions/upload-artifact@v2
overwrite: true
- uses: actions/upload-artifact@v4
if: matrix.os.name == 'windows'
with:
name: luau-${{matrix.os.name}}
path: Release\luau*.exe
overwrite: true

web:
runs-on: ubuntu-latest
Expand All @@ -52,7 +54,8 @@ jobs:
source emsdk/emsdk_env.sh
emcmake cmake . -DLUAU_BUILD_WEB=ON -DCMAKE_BUILD_TYPE=Release
make -j2 Luau.Web
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
with:
name: Luau.Web.js
path: Luau.Web.js
overwrite: true

0 comments on commit cd1803e

Please sign in to comment.