Skip to content

Commit

Permalink
Work around ASLR+ASAN compatibility issues in GHA (#1203)
Browse files Browse the repository at this point in the history
vm.mmap_rnd_bits has been recently changed to 32 on GHA, which triggers
issues in ASAN builds that spuriously fail on startup. The fix requires
a more recent clang/gcc than the agents have available (clang 17, not
sure what GCC version), so for now we need to work around this by
restricting the ASLR randomness.

See google/sanitizers#1614
  • Loading branch information
zeux authored Mar 15, 2024
1 parent 9aa82c6 commit d2ed215
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ jobs:
runs-on: ${{matrix.os.version}}
steps:
- uses: actions/checkout@v1
- name: work around ASLR+ASAN compatibility
run: sudo sysctl -w vm.mmap_rnd_bits=28
if: matrix.os.name == 'ubuntu'
- name: make tests
run: |
make -j2 config=sanitize werror=1 native=1 luau-tests
Expand Down

0 comments on commit d2ed215

Please sign in to comment.