fixed duplication of static function Luau::Codegen::hasTypedParameters #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We already have IrUtils, I don't think it's worth adding a new file for a single function that seems to specialize on what can be done with a Proto type. Considering how minor the issue is. I would suggest exposing the BytecodeAnalysis implementation in BytecodeAnalysis.h and using that in IrBuilder that already includes and depends on the BytecodeAnalysis.h. |
|
Should I move BytecodeAnalysis.h to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function definition and directive
#include "lobject.h"have been moved to a separate header file.