FastAPI Integration #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in our tests to test integration with Starlette & FastAPI
…ption if fastapi is not installed
|
Before merging, make sure that async routes are supported, and run perfsephone on a number of projects (this should also be automated at some point) |
|
Superseded by #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, profiling a FastAPI router using perfsephone yielded a useless trace, only showing that fastapi is waiting for some external thread pool to finish executing some code without showing the actual code being executed in the thread pool.
With this PR, you may see that the FastAPI route code that is executed on the thread pool is now tracked: