Skip to content

refactor(comment): drop the dead comment-autosave machinery #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luflow merged 2 commits into from
Aug 15, 2026
Merged

refactor(comment): drop the dead comment-autosave machinery #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40e2927
refactor(comment): drop the dead comment-autosave machinery
claude Aug 13, 2026
ed1c19b
refactor(comment): apply review cleanups to the comment save path
claude Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/components/appointment/ResponseEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@

<script setup>
import { NcButton, NcInputField } from '@nextcloud/vue'
import { computed, nextTick, onBeforeUnmount, ref, watch } from 'vue'
import { computed, nextTick, ref, watch } from 'vue'
import CheckCircle from 'vue-material-design-icons/CheckCircle.vue'
import ClockIcon from 'vue-material-design-icons/Clock.vue'
import CloseCircle from 'vue-material-design-icons/CloseCircle.vue'
Expand Down Expand Up @@ -135,7 +135,7 @@ const localComment = ref(props.comment)
const commentExpanded = ref(Boolean(props.comment) && !props.compact)
const commentInput = ref(null)

const { savingComment, errorComment, autoSaveComment, reset } = useAppointmentResponse()
const { savingComment, saveComment: saveCommentApi } = useAppointmentResponse()

// Saving a comment does not refresh the parent, so props.comment stays on the
// value the card was rendered with. Without a local baseline the Save button
Expand Down Expand Up @@ -165,15 +165,11 @@ watch(() => props.comment, (next) => {
async function saveComment() {
if (!commentChanged.value || savingComment.value) return
const pending = localComment.value
await autoSaveComment(props.appointmentId, props.userResponse, pending, false)
if (!errorComment.value) {
const saved = await saveCommentApi(props.appointmentId, props.userResponse, pending)
if (saved) {
savedComment.value = pending
}
}

// The composable keeps its own spinner/indicator timeouts, which would
// otherwise keep writing into refs of an unmounted card.
onBeforeUnmount(reset)
</script>

<style scoped lang="scss">
Expand Down
Loading
Loading