Let the consolidation string carry its own count - #178
Merged
Conversation
The mobile paywall spelled out "three personal licenses", which only
held while the personal plan cost €11.99. The app now derives that
number from the store prices, so the string takes it as {count}.
"Less than one euro a month" goes with it — the app quotes the store's
own monthly figure through the existing "That is {price} a month."
php-cs-fixer flags it on PHP 8.1, which is what CI runs; on newer PHP the same fixer stays quiet, so it slipped through when the last Talk refactor trimmed a method out of the stub.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with luflow/attendance-flutter#84 — needs to land together, the app already uses the new key.
Was sich ändert
Im Registrierungsblock für die Mobile-Strings:
Using Attendance with a group? One license for the whole group costs less than {count} personal licenses.Less than one euro a month— die App zeigt stattdessen den vom Store gerechneten Monatspreis über den vorhandenen StringThat is {price} a month.Der Translator-Kommentar zur neuen Zeile sagt, dass
{count}eine Anzahl Lizenzen ist und die Zahl bewusst nicht ausgeschrieben wird.Test
npm run buildgrün, Drift-Checker der Flutter-App meldet weder MISSING noch STALE.🤖 Generated with Claude Code