fix(docs): escape MDX JSX openers in generated reference tables#40
Merged
Conversation
gen:reference emitted description prose like `currency:<CODE>` verbatim into
table cells; MDX parsed `<CODE>` as an unclosed JSX tag and failed the build.
cell() now escapes `<` and `{` alongside the pipe, matching the header
contract. Regenerated manifest.mdx (also picks up stale schema sync).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The docs build failed on
main:buildrunsgen:referencefirst, which regeneratesmanifest.mdx. A schema field description reads…use 'currency:<CODE>' (e.g. currency:RSD), and the generator emitted that prose verbatim into a table cell. MDX parsed<CODE>as a JSX tag, found no closer, and aborted the build.Fix
cell()ingen-reference.tsonly escaped the pipe, even though its header comment promised cells "stay free of unescaped{ } < >". It now also escapes MDX's JSX/expression openers<and{, so any bracket-bearing description renders as literal text.renderTypenever emits these characters, so type cells are unaffected.Regenerated
manifest.mdxis included — the committed copy was also stale, so the diff additionally reflects current schema (daterangedefault, querysearch,currency:<CODE>formats).Verification
pnpm gen:reference→currency:\<CODE>in outputpnpm buildinapps/docscompletes (prerender + postbuild succeed)