build: simplify setup with Vite v2.9 #45
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft proposes simplifying the build setup.
With the release of Vite version 2.9 several worker issues have been fixed, including
However, the current state of this branch is not working with, e.g. the vite-ts test app. Building the library works as expected with the simplified setup, but importing the lib into the test app does not work. The main problem seems to be that Vite resolves the
new URL(..., import.meta.url)pattern and replaces it with a path (without the URL constructor) during build, but then the Vite app is not able to resolve the worker files.This needs more investigation and maybe requires creating another issue in Vite, but this PR can serve as a base for further investigation.