Skip to content

added bitcoin support #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added bitcoin support #64

wants to merge 1 commit into from

Conversation

ryan-lang
Copy link

added create_bitcoin_receiver(), get_bitcoin_receiver(), and list_bitcoin_receivers(). Also updated the documentation on post_charge(), which can now accept a Bitcoin receiver id (analogous with a card token.) addresses #63

@ryan-lang
Copy link
Author

I should also note that the new Stripe api encourages using the parameter "source" rather than "card" for cards, tokens, and bitcoin, but I decided to leave that alone for now since that's a more substantial update.

@andrewsolomon
Copy link
Collaborator

Unfortunately this breaks unit tests for me because I don't have a USD bank account

ok 79 - charge was paid
Error: invalid_request_error - For 'bitcoin_receiver' payments, we currently require your Stripe account to have a bank account in the currency of the payment (usd) On parameter: currency
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 79.
Error: invalid_request_error - For 'bitcoin_receiver' payments, we currently require your Stripe account to have a bank account in the currency of the payment (usd) On parameter: currency
Dubious, test returned 255 (wstat 65280, 0xff00)
All 79 subtests passed 

@sherrardb sherrardb force-pushed the master branch 2 times, most recently from aec2a9f to 43da122 Compare January 26, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants