-
-
Notifications
You must be signed in to change notification settings - Fork 133
version 1.18.0 #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 1.18.0 #75
Conversation
bump version
|
@lukechilds could you please check, and let me know if ok for you |
|
Would be nice to see 🙏 |
|
@maltokyo v1.18.0 already out. |
|
Without response here, I now just build my own, shame this one is unmaintained |
|
Apologies guys, I've been very busy on other things. Have you tested this and it's working? I'll merge now if so. |
|
@maltokyo this fails to build for me: |
Same here @maltokyo PS: Since it is open source, no shaming initial maintainers 🫂 |
|
Sorry I just built offline, as I thought this was not maintained. No time these weeks, would be good if someone else could pick up with 1.18 |
|
All good! Very limited on time atm but if anyone wants to pick this up I'll try and be more responsive at giving things a quick test and merge. |
|
@lukechilds @theborakompanioni I got some time to do this today. Luke please could you check, and merge when you can. I tested this by the way, it now builds fine for me. |
|
It builds for me but fails to run due to missing uvloop dependency: |
|
Apologies @lukechilds - I didn't see that in dependencies in the electrumx server docs. I think I have fixed that, could you please try again (sorry, I don't have a server accessible to test on at the moment). |
|
Ok, after a lot os screwing around trying to get it to work in Alpine (I failed) I switched over to Debian slim. Everything testing, and the container runs fine. Please merge @lukechilds |
|
Thanks @maltokyo
Yeah it's not a requirement, it's something i added in this project to workaround this bug: Thanks for your help, I have tweaked the dockerfile slightly and split things up into separate commits. I have given you commit credits in this commit 5fdabd7 Thanks for your help! |
|
Made PR for BTCPay Server, as this is a breaking change. I dont know which other apps use your image @lukechilds, but better to let them know if you know of any. |
|
I think we can just auto handle it in the init script to migrate old env vars over. And we can just default to Bitcoin so most users don't need to manually set it. Working on it now. |
|
This should handle it automatically: bcaeabf. The |
|
great, thanks!! |
bump version
https://github.com/spesmilo/electrumx/releases/tag/1.17.0