Url regeneration fix for attributed data #2115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it aware of attribute of name, otherwise use the column, when generating a slug.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…thub.com/AaronNeonDigital/getcandy into url-regeneration-fix-for-attributed-data
|
Deployment failed with the following error: |
…thub.com/AaronNeonDigital/getcandy into url-regeneration-fix-for-attributed-data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing the UrlGenerator class, which does not account for the way Brands currently function.
Brands have the column name, and if you add attributes to it, then no urls will be generated (as it stands).
In this PR we focus the Url Generation to take priority on the column name, instead of attributes. We also adapted it, so it only checks for the attribute of "name", before proceeding.
and finally, we cleaned the method up so we are not nesting if statements.