History service improvements [Closes #908]#910
Open
rpulkka wants to merge 1 commit intodevelopmentfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #908
Branch: https://807.dev.laji.fi/project/MHL.1166/form/MHL.1166/places?activeNP=MNP.56680
On addresses with replaceUrl (meaning that only the latest query param change should be saved to history) there was an issue that the first visit to the replaceUrl didn't get saved. So reload on a replaceUrl page with params -> going to another page -> coming back would lose query params and now it doesn't because of this if case:
if (this.router.currentNavigation()?.extras.replaceUrl)Also, the confusing
hasBackvariable was replaced withisInitialLoadto check the situation where user loads the first page on the first time. Note that /user, /login and /logout paths are also now considered inisInitialLoadwhich makes home-data.service use cache-first on them as well, unlike the earlier no-cache.getPreviouswas deleted as we can usebrowserService.goBackinonDocumentDeleted.