feat: CLI v2 Phase 2 — smart play, history subcommand, unified AI#13
Merged
feat: CLI v2 Phase 2 — smart play, history subcommand, unified AI#13
Conversation
…e validation (CLI v2 Phase 2) Implements all 11 subtasks from issue #10: - 2.1: Smart play [SOURCE] auto-detection (file/YouTube/URL/station/context) - 2.2: Deprecation warning on play -m ai - 2.3: Deprecation warning on play -m history - 2.4: Convert history to group with list + play N subcommands - 2.5: Move update-radios to radio update (old form hidden alias) - 2.6: Rename ai models to ai model, set-default to default (old forms aliased) - 2.7: Unify AI --duration default to 15 on both paths - 2.8: mc mood MOOD plays mood radio directly - 2.9: Volume validation with IntRange(0, 100) - 2.10: Replace all music-cli references with mc in help/echo text - 2.11: 70 new tests covering all Phase 2 features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements all 11 subtasks from CLI v2 Phase 2, building on the Phase 1 foundation from #9.
play [SOURCE]: Auto-detects mode from positional argument (file path -> local, YouTube URL -> youtube, HTTP URL -> radio stream, station name -> radio, bare -> context)play -m aiandplay -m historywarn users to usemc ai play/mc history play Ninsteadhistorygroup: Converted from command to group withlistandplay Nsubcommands;halias continues to workradio update: Movedupdate-radiosintoradio update; old command kept as hidden aliasai model: Renamedmodels->model(singular),set-default->default; old names kept as hidden aliases--durationdefault to 15 seconds on bothplay -dandai play -dmood MOOD:mc mood focusdirectly starts mood-based radio playbackvolargument now usesIntRange(0, 100)— rejects out-of-range valuesmusic-clireferences replaced withmcin echo/help stringsCloses #10
Test plan
mc play ~/file.mp3auto-detects local modemc play https://youtube.com/watch?v=xxxauto-detects YouTube modemc play jazzauto-detects station nameplay -m aiandplay -m historyshow deprecation warningsmc history play 3replays from historymc radio updateworks, oldupdate-radiosstill worksmc ai model default Xworks--durationdefaults to 15 on both pathsmc mood focusstarts focus radio playbackmc vol 150rejects with range errormusic-clireferences remain in help/echo text