Fix bind if ceph_ip_address is set

[breml]

Fixes #44

@gregoryguillou you might want to have a look at a077db6. Since you have refactored the ansible playbook to roles and added the support to use it as ansible collection, the repository was no longer self-sufficient in the sense, that one could easily alter the code and just run it. After changing an existing role, it was always required to re-install the collection in order to make ansible pick up the changes.

[gregoryguillou]

1- Thank @breml for pointing me that parameter! You are right, I am reinstalling the collection after each change with ansible-galaxy. I'll check if that fixes my issue and detect the changes

2- I was thinking from #44 that the IP you were using for Ceph was IPv4 and I would have expected to use ansible.utils.ipv4 at some point to change the line you are changing. I know there are other issues and my understanding is that tests somehow assume we are running IPv6. For instance, you can check the [\\1] below which I assume should not work with IPv4:

• incus-deploy/roles/ceph/templates/ceph.conf.j2

  Line 2 in 52d9582

  {% set addresses = monitors | map(attribute='ip') | map('regex_replace', '^(.*)$', '[\\1]:6789') | sort | join(',') -%}

• incus-deploy/roles/incus/vars/main.yml

  Line 4 in 52d9582

  incus_ovn_northbound: "{{ lookup('template', 'ovn-central.servers.j2') | from_yaml | map('regex_replace', '^(.*)$', 'ssl:[\\1]:6641') | join(',') }}"

[stgraber]

@breml @gregoryguillou what's going on with this one?

[gregoryguillou]

@breml @gregoryguillou what's going on with this one?

This PR introduces a default value (empty string) for ceph_ip_address as pointed in the comments above. This leads to an error when ceph_ip_address is not set. When it is the case, this template truns into - ip: instead of ip: <default_ip>. The simplest fix to me is to leave ceph_ip_address undefined and remove the , true) from the default syntax.

In addition, the roles_path is not relevant anymore because roles are now prefixed with the collection as recommended by the linter.

@breml did 90% of the work so I was thinking he would be interested to fix the issue. If needed, I can fix the PR and pass the tests later this week...

[breml]

@gregoryguillou Feel free to fix the PR. I have not had the time to look at this for the past weeks, I was chasing other priorities, sorry.