Fix Multiplayer Battle End Condition - Resolves #355

[Owenb135]

Fix Multiplayer Battle End Condition - Resolves #355

Problem:

Multiplayer battles were unable to end properly due to an infinite loop in the outer battle loop. When a player ran out of Pokémon or all opponent Pokémon fainted, the break statement only exited the inner decision loop, causing the outer loop to continue indefinitely and restart rounds instead of concluding the battle.
Root Cause Analysis

The issue occurred at lines 144-147:

if not loser.handle_defeat(ctx, self.fightmap, winner):
    break  # ❌ Only breaks inner while loop

else:
    break
index += 1  # ❌ Always executed, restarting outer loop

The break statements only exit the inner decision loop (while True at line 79), while control flow continues to the outer battle loop (while True at line 73), causing the battle to restart instead of concluding.
Solution

Introduced a fight_over flag to properly control the outer battle loop termination:

• Line 73: Changed outer loop condition from while True: to while not fight_over:
• Lines 144-147: Set fight_over = True when battle end conditions are met
• Lines 149-150: Only increment index if fight_over remains False

This ensures the battle properly exits and transitions to the victory screen when:

A player defeats all opponent Pokémon
A player runs out of active Pokémon

Testing Notes

✅ AI-assisted code review completed — Logic flow verified for all battle end scenarios:

Victory by opponent KO
Victory by opponent player exhaustion
Proper exit to victory screen and XP distribution
No regression in escape mechanics or item usage

Impact

Fixes infinite loop in multiplayer battles
Allows proper battle conclusion and winner determination
Enables correct XP and stat tracking post-battle

[Owenb135]

Please run workflows on it. Merge