Skip to content

mainmenu: Compare duplicated actions based on desktop filename#2341

Open
City-busz wants to merge 1 commit into
lxqt:masterfrom
City-busz:compare-actions
Open

mainmenu: Compare duplicated actions based on desktop filename#2341
City-busz wants to merge 1 commit into
lxqt:masterfrom
City-busz:compare-actions

Conversation

@City-busz

Copy link
Copy Markdown
Contributor

Comparing name and comment is not reliable, as in some cases multiple apps may use the same name.

@tsujan

tsujan commented Sep 29, 2025

Copy link
Copy Markdown
Member

Comparing name and comment is not reliable

The name and the comment are what is shown in the menu. It doesn't make sense to show items that aren't distinguishable from each other.

in some cases multiple apps may use the same name.

If those apps use the same name and comment, the problem should be fixed in them.

@City-busz

Copy link
Copy Markdown
Contributor Author

On Arch Linux, there are two versions of gImageReader: gimagereader-gtk and gimagereader-qt, but both desktop files have the same name and comment. This is actually valid, the standard does not prohibit this, only the .desktop filename must be unique. Without this change, only one of them is visible during a search. I know this is rare, but it's technically more correct to show both rather than only one of them.

@tsujan

tsujan commented Sep 29, 2025

Copy link
Copy Markdown
Member

the standard does not prohibit this

OK, but it's problematic in practice. If gimagereader-gtk and gimagereader-qt have the same name and the same comment, and if they can be installed alongside each other, there's no way to distinguish them from each other when they're shown in a menu. Their author(s) should change a name and/or a comment — after all, they're different, and that difference should be visible before launching them.

Comparing name and comment is not reliable, as in some cases multiple
apps may use the same name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants