Skip to content

Prioritize system icons for networkmonitor plugin#2457

Merged
ahsand97 merged 5 commits into
lxqt:masterfrom
ahsand97:prioritize-system-icons
Jul 16, 2026
Merged

Prioritize system icons for networkmonitor plugin#2457
ahsand97 merged 5 commits into
lxqt:masterfrom
ahsand97:prioritize-system-icons

Conversation

@ahsand97

Copy link
Copy Markdown
Contributor

No description provided.

@ahsand97 ahsand97 changed the title Prioritize system icons Prioritize system icons for networkmonitor plugin Jul 14, 2026
@stefonarch

Copy link
Copy Markdown
Member

It works fine but this setting is useless/not respected now, should it have a "From system" item at the top?
immagine

@ahsand97

ahsand97 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

It works fine but this setting is useless/not respected now, should it have a "From system" item at the top? immagine

That make sense, but wait, should we remove the setting then to use this new behavior, going for system icons or instead add a new option there? like "System" plus the other ones? Or maybe another option "Prefer system icons" like a checkbox that would disable the drop-down?

@tsujan

tsujan commented Jul 14, 2026

Copy link
Copy Markdown
Member

Or maybe another option "Prefer system icons" like a checkbox that would disable the dropdown?

I like this idea, with that box checked by default. My reason is twofold: it's clean, and system icons are more fundamental.

Comment thread plugin-networkmonitor/lxqtnetworkmonitor.cpp Outdated
@stefonarch

Copy link
Copy Markdown
Member

I went through my installed themes and only breeze hadn't the icon and the choice worked. The checkbox is a good solution IMO.

@ahsand97

Copy link
Copy Markdown
Contributor Author

Done

@stefonarch

Copy link
Copy Markdown
Member

Looks good now, thanks!

@tsujan tsujan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@tsujan

tsujan commented Jul 16, 2026

Copy link
Copy Markdown
Member

@ahsand97
Since the PR is approved by 2 members (@stefonarch has practically done so too), if you don't want to change the patch, you could merge it by clicking the button "Squash and merge" and …. But if you change the patch for whatever reason, please wait for another approval after that.

@ahsand97 ahsand97 merged commit 83497f7 into lxqt:master Jul 16, 2026
@ahsand97 ahsand97 deleted the prioritize-system-icons branch July 16, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants