Repository navigation
fix: describe-ui --no-raw review follow-ups - #69
Merged
Merged
Conversation
The --json help still unconditionally claimed the envelope includes the raw bridge tree under `data.raw`; since #63 that only holds when --no-raw is not passed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fyffe82rd7F7eqvXFVJtz4 Signed-off-by: onevcat <onevcat@gmail.com>
snapshotSpawnsNoRaw rewrote the fake-binary script after the fact to capture its argv, coupling the test to the fixture's exact file content (shebang line included). Recording is now a makeHandlers option — the script writes "$@" to "$0.args" before replaying the scripted output — read back via a recordedArgs(of:) helper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fyffe82rd7F7eqvXFVJtz4 Signed-off-by: onevcat <onevcat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small follow-ups from the #63 review, as noted in this comment:
--jsonhelp text: it still unconditionally claimed the envelope "Includes the raw bridge tree underdata.raw" — since feat: describe-ui --no-raw and skill guidance to keep agent context small #63 that only holds when--no-rawis not passed. The help now says so. (The inaccuracy never shipped, so no CHANGELOG entry.)snapshotSpawnsNoRawrewrote the fake-binary script post-hoc to capture its argv, coupling the test to the fixture's exact file content (shebang line included). Recording is now amakeHandlers(recordArgs:)option — the script writes"$@"to"$0.args"before replaying the scripted output — read back through arecordedArgs(of:)helper. The.argsfile lives in the per-test temp dir, so the existing cleanup covers it.Tests
make test: 1123 green, coverage 68.3%.🤖 Generated with Claude Code
https://claude.ai/code/session_01Fyffe82rd7F7eqvXFVJtz4