Update ANN inference in MOM_Zanna_Bolton #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main goals:
ANN_apply_array_sio_r4
(1.5-2 times faster thanANN_apply_array_sio
)In the global ocean model OM4, the new algorithm takes less than 5% of runtime:
Regression changed compared to the initial commit to
dev/m2lines
for a few reasons:compute_stress_ANN_collocated
in favour of grouping all exchanges into one function call. This does not affect idealized simulations but affects the prediction on tripolar fold where rotational invariance of all expressions is required to have the same regression1/sqrt()
incompute_stress_ANN_collocated