Open
Conversation
Signed-off-by: alingse <alingse@foxmail.com>
linasm
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #
I was running github actions to run linter makezero for top github golang repos.
see issues alingse/go-linter-runner#1
and the github actions output
https://github.com/alingse/go-linter-runner/actions/runs/9242655147/job/25425748900
but the linter can't find the
make(sort.StringSlice, len(*t))so not reported in the actions outputSpecial notes for your reviewer
this is not cause a real bad bug because the
[]stringwas sort and finally called byWriteString(s)so the empty value string was save in the slice but ignored when called by
WriteStringDoes this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: