[buildkite] Fix "Codegen" test in buildkite pipeline#4312
Open
kentzeng12 wants to merge 16 commits intomasterfrom
Open
[buildkite] Fix "Codegen" test in buildkite pipeline#4312kentzeng12 wants to merge 16 commits intomasterfrom
kentzeng12 wants to merge 16 commits intomasterfrom
Conversation
…ainer created by proto-gen.sh
andrewmains12
requested changes
Nov 26, 2024
Contributor
andrewmains12
left a comment
andrewmains12
left a comment
There was a problem hiding this comment.
We need to figure out a way to get a consistent protoc compiler version here; otherwise we're likely to run into trouble.
| $UID_FLAGS $PROTOC_IMAGE_VERSION \ | ||
| --gogofaster_out=${resolve_protos},plugins=grpc:/src \ | ||
| -I/src -I/src/github.com/m3db/m3/vendor ${proto_files} | ||
| protoc --gogofaster_out=${resolve_protos},plugins=grpc:${GOPATH}/src \ |
Contributor
There was a problem hiding this comment.
I think we should try to stick with the containerized protobuf here ideally--we want to use a consistent protobuf version, rather than whatever the developer has "lying around".
| RUN apt-get update && apt-get install -y lsof netcat-openbsd docker.io jq | ||
| RUN apt-get update && apt-get install -y lsof netcat-openbsd docker.io jq protobuf-compiler thrift-compiler | ||
|
|
||
| RUN go install github.com/gogo/protobuf/protoc-gen-gogofaster@latest |
Contributor
There was a problem hiding this comment.
Same comment--we want a consistent set of versions for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes "Codegen" test in buildkite pipeline.
Fixes #4274
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
No
Does this PR require updating code package or user-facing documentation?:
No