[feat/query] Update the Prometheus-related code to utilize the new annotations package, and adjust the signatures of the query methods to support context passing.#4319
Open
xufeng0832 wants to merge 2 commits intom3db:masterfrom
Conversation
…for metric and label names, utilize the new annotations package, and adjust the signatures of the query methods to support context passing.
|
|
xufeng0832
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Update the Prometheus-related code to support UTF - 8 for metric and label names, utilize the new annotations package, and adjust the signatures of the query methods to support context passing.
What this PR does / why we need it:
When a dot (.) is included in metrics or labels, it will cause the query to fail and prevent the retrieval of metrics.
Fixes #
Special notes for your reviewer:
No
Does this PR introduce a user-facing and/or backwards incompatible change?:
No
Does this PR require updating code package or user-facing documentation?:
Yes.However, my English is not very good, and I need assistance with updating the documentation.