Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Termux Compatibility#16

Open
maxugly wants to merge 16 commits intom4sc0:masterfrom
maxugly:master
Open

Termux Compatibility#16
maxugly wants to merge 16 commits intom4sc0:masterfrom
maxugly:master

Conversation

@maxugly
Copy link

@maxugly maxugly commented Jun 12, 2025

This update makes the /tmp references use a system variable for better portability, now working on termux.

maxugly added 3 commits June 11, 2025 13:04
Fixed /tmp hardwired instances
Changed /tmp references to global variable references
@m4sc0
Copy link
Owner

m4sc0 commented Jun 12, 2025

Thanks a lot for this contribution! Quick question about the CRUD stubs and the multiple import attempts: what was the idea behind adding the CrudStub class + all the fallback imports? From what I’m seeing, the stub only kicks in if literally all import attempts fail, which I’d guess isn’t too common. Is that the main necessity for TWD to work with Termux?
Thanks again for the great work!

Better visibility on android, hard coded colors for now. Will be adding a flag or something to turn color off/on. Also, potential to create separate themes? Also, soon making toggle keys for the id and created columns
@m4sc0
Copy link
Owner

m4sc0 commented Jun 12, 2025

I hate to be the bad guy, but please make a new feature request for things like coloring in the future. PR's should only revolve around one topic. This one was for compatibility issues with Termux. The next can be "adding colors" and so on... I'm gonna write a Contribution info in the near future, please keep to it. Thanks!

@maxugly
Copy link
Author

maxugly commented Jun 12, 2025

I hate to be the bad guy, but please make a new feature request for things like coloring in the future. PR's should only revolve around one topic. This one was for compatibility issues with Termux. The next can be "adding colors" and so on... I'm gonna write a Contribution info in the near future, please keep to it. Thanks!

I'm sorry, man. This is my first time using GitHub or git in general. I meant to separate them but need to learn to do so properly. Thanks for letting me contribute, TWD is exactly what I was looking for. Seriously, it makes jumping around 10x easier on my phone!

@m4sc0
Copy link
Owner

m4sc0 commented Jun 12, 2025

Absolutely no problem. Great to hear that you're using TWD actively and that you can even learn to use GitHub/git properly.

If you need help with contribution heck out this guide from the GitHub Docs. It's a little bit more work for me now, but that also helps me learn new stuff (never had to use cherry-picking in git before lol). Therefore, don't worry about it ^^

@maxugly
Copy link
Author

maxugly commented Jun 12, 2025

Thanks a lot for this contribution! Quick question about the CRUD stubs and the multiple import attempts: what was the idea behind adding the CrudStub class + all the fallback imports? From what I’m seeing, the stub only kicks in if literally all import attempts fail, which I’d guess isn’t too common. Is that the main necessity for TWD to work with Termux? Thanks again for the great work!

Again, I should not have pushed all that to main. It was my brute force way of getting around the differences in how termux is doing things. Convential wisdom and the solutions I found to my problems were for Linux distros and not Termux. Surely it is overkill. I will have to go back as I learn and clean that up. Now that TWD is working I can hop around a lot easier and learn all the default paths and structure.

@m4sc0
Copy link
Owner

m4sc0 commented Jun 16, 2025

Hey, I appreciate your work on TWD a lot. But I've noticed that you're making changes unrelated to this issue (#15). I just wanna make sure you understand that I would like this to be structured properly (i.e. that one issue is for one topic and one topic only). This said, can you make sure you create the respective issues for example for touch support and the PR's appropriately.
Thank you!

maxugly added 2 commits June 26, 2025 16:37
Sorry, I don't understand why each change I make is not its own pull request. I don't get git. I would try to learn it if anything about it was intuitive or you could ROLL BACK A MISTAKE...

hopefully soon I will be laughing at this from my nice chair I bought with my monetized code that I could only have built with git
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants