Skip to content

fix: Prevent Database Growth When ATT Status Denied #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Prevent Database Growth When ATT Status Denied #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mParticle-Apple-SDK/Network/MPNetworkCommunication.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,9 @@ - (NSNumber *)maxAgeForCache:(nonnull NSString *)cache {
}

- (void)checkResponseCodeToDisableEventLogging:(NSInteger)responseCode {
if (responseCode == HTTPStatusCodeBadRequest || responseCode == HTTPStatusCodeUnauthorized || responseCode == HTTPStatusCodeForbidden) {
NSNumber *currentStatus = [MParticle sharedInstance].stateMachine.attAuthorizationStatus;

if (responseCode == HTTPStatusCodeBadRequest || responseCode == HTTPStatusCodeUnauthorized || responseCode == HTTPStatusCodeForbidden || currentStatus.integerValue == MPATTAuthorizationStatusDenied) {
[MPStateMachine setCanWriteMessagesToDB:NO];
MPILogError(@"API Key appears to be invalid based on server response, disabling event logging to prevent excessive local database growth");
} else {
Expand Down
7 changes: 7 additions & 0 deletions mParticle-Apple-SDK/mParticle.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,6 +1047,13 @@ - (void)setATTStatus:(MPATTAuthorizationStatus)status withATTStatusTimestampMill
if (attStatusTimestampMillis != nil) {
[MParticle sharedInstance].stateMachine.attAuthorizationTimestamp = attStatusTimestampMillis;
}

if (status == MPATTAuthorizationStatusDenied) {
[MPStateMachine setCanWriteMessagesToDB:NO];
MPILogError(@"ATT Status is denied, disabling event logging to prevent excessive local database growth");
} else {
[MPStateMachine setCanWriteMessagesToDB:YES];
}
}
}

Expand Down