Skip to content

test: add coverage for logscreen methods #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 4, 2025
Merged

test: add coverage for logscreen methods #440

merged 14 commits into from
Nov 4, 2025

Conversation

@nickolas-dimitrakas
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Oct 31, 2025 •
edited
Loading

Background

  • Added unit tests to increase coverage for logScreen and logScreenEvent methods.

What Has Changed

  • Added new Swift tests covering:
  • Full execution flow of logScreenEvent.
  • Event blocking when a dataPlanFilter is set.
  • Validation of logger output and callback handling.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

image

Reference Issue (For employees only. Ignore if you are an outside contributor)

@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner October 31, 2025 19:29
denischilik
denischilik approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas merged commit 52bf614 into main Nov 4, 2025
10 of 11 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the test/add-coverage-for-logscreen-methods branch November 4, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@denischilik denischilik denischilik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickolas-dimitrakas @BrandonStalnaker @denischilik