feat: SDKE-221 Support hashedEmailUserIdentityType for "other" identity type

[rmi22186]

Instructions

1. PR target branch should be against development
2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

In this PR, we make an identify call if emailsha256 passed to selectPlacement differs from the other identity value.

Testing Plan

• Was this tested locally? If not, explain why.
  Integration tests and tested in an app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

• Closes https://go.mparticle.com/work/SQDSDKS-7619

[sonarqubecloud]

Quality Gate failed

Failed conditions
64.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[BrandonStalnaker]

With Web you can identify with more than 1 identity at a time right? I just think if you need to identify with either you should just identify with both rather than possibly identifying twice.

[BrandonStalnaker]

So !! is a double not right so it doesn't invert like not(!), it just converts to a boolean?

So this would be = ((newEmail != nil && currentEmail == nil) || (newEmail != nil && currentEmail !== newEmail))

[BrandonStalnaker]

Looks good as long as my understanding of the logic is right

[Mansi-mParticle]

Logic looks good to me

[alexs-mparticle]

If configSettings is just a copy of settings, we should move it above the extraction of placementAttributesMapping, and combine the destructuring of placementAttributesMapping and hashedEmailUserIdentityType.

[rmi22186]

@alexs-mparticle not sure I follow. Destructuring hashedEmaiLuserIdenittyType from settings so that I can use it in selectPlacements would require me to place a new setting on the Rokt class. Is that what you are suggesting? It's not used in the current init function

[alexs-mparticle]

If you do this here:

        const { userAttributeFilters, settings } = roktConfig || {};
        const { placementAttributesMapping, hashedEmailUserIdentityType } = settings || {}; 

Then you can avoid doing this later in the file:

     const { hashedEmailUserIdentityType = null } = this.configSettings || {};

And then we don't need to store configSettings on this.

[rmi22186]

Closing the loop here - confirmed with Alex that we shodl set it on the Rokt Class and not just destructure it so it can be used later.

[alexs-mparticle]

I would avoid using double bang (!!) in these checks because it makes it hard to read what's going on here. I think we created https://go.mparticle.com/work/SQDSDKS-7338 to refactor this into something readable, so now would be a great time to clean this up.

[rmi22186]

@alexs-mparticle please take another look

[alexs-mparticle]

Do you still need to do this since it's in the beforeEach?

Suggested change

	// Reset mocks
	jest.clearAllMocks();

[sonarqubecloud]

Quality Gate failed

Failed conditions
26.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud