Add Fan RPM sensors to Hot #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2024
siravijbb
approved these changes
Jan 26, 2025
strange-suraj
approved these changes
Jul 2, 2025
|
Should we expect this to be released any time soon? |
Author
|
I see approvals, but I still can't merge this branch. Also, there are two related PR's in the submodules that need to land first: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Fan RPM sensors to Hot.
In the main menu bar drop down, there is a Fan RPM combined indicator and a Fan flyout menu to show the individual fan speeds:
The detach graph view also includes Fan RPM:
And the Sensors dialog has Fan RPM sensors:
Changes were need in the Submodule
SensorsandSensorsKitrepos:macmade/Sensors#5
macmade/SensorsKit#1