Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: fix build on old macOS; support ruby31 #26012

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

barracuda156
Copy link
Contributor

Description

See commits

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@raimue for port vim.

@barracuda156 barracuda156 changed the title vim: fix build on old macOS, support ruby31 vim: fix build on old macOS Sep 30, 2024
@barracuda156
Copy link
Contributor Author

Won't bother with ruby stuff, since it fails:

In file included from /opt/local/include/ruby-3.1.4/ruby/ruby.h:25,
                 from /opt/local/include/ruby-3.1.4/ruby.h:38,
                 from if_ruby.c:110:
/opt/local/include/ruby-3.1.4/ruby/defines.h:55:23: error: stdalign.h: No such file or directory
2949 translated messages.

Let's just fix building on old macOS here.

@barracuda156
Copy link
Contributor Author

barracuda156 commented Sep 30, 2024

Ah, wait, it works with the right gcc picked. Modern ruby uses modern gcc, so Xcode one cannot build this with ruby enabled.

UPD. Should be good now.

@barracuda156 barracuda156 changed the title vim: fix build on old macOS vim: fix build on old macOS; support ruby31 Sep 30, 2024
raimue added 2 commits October 2, 2024 20:00
Synchronize these changes from the vim Portfile.
Synchronize these changes from the vim Portfile.
@raimue
Copy link
Member

raimue commented Oct 2, 2024

Looks good to me! I also synchronized the changes to the MacVim port as far as they apply. Thanks for the port update.

@raimue raimue merged commit 42e1771 into macports:master Oct 2, 2024
3 checks passed
@barracuda156 barracuda156 deleted the vim branch October 3, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants