Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glaze: new port #27339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

glaze: new port #27339

wants to merge 1 commit into from

Conversation

sikmir
Copy link
Contributor

@sikmir sikmir commented Jan 8, 2025

Description

glaze - extremely fast, in memory, JSON and interface library for modern C++.

Packaging status

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.7.6 x86_64
Xcode 14.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

reneeotten
reneeotten reviewed Jan 9, 2025
View reviewed changes
devel/glaze/Portfile
sha256 72cd174ad8839bc526a679a5a8ebf4bb18f3cb850a34fcfd3e89970f83c4d384 \
size 546532

compiler.cxx_standard 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that this does anything; is this actually defined in "macports-base"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if the port is "noarch" it implies nothing gets compiled so why would this be needed at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what about tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that this does anything; is this actually defined in "macports-base"?

I'm not sure, but it's used:

sysutils/caps-log/Portfile:34:compiler.cxx_standard   2023
textproc/vectorscan/Portfile:58:compiler.cxx_standard   2023

@reneeotten
Copy link
Contributor

ping @sikmir

@reneeotten
Copy link
Contributor

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten left review comments

Assignees
No one assigned
Labels
type: enhancement type: submission
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sikmir @reneeotten @macportsbot