Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libomp: use newer python for new systems #27517

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

i0ntempest
Copy link
Member

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@eborisch for port libomp.

@macportsbot macportsbot added type: enhancement maintainer: open Affects an openmaintainer port by: member Created by a member with commit rights labels Jan 26, 2025
@i0ntempest
Copy link
Member Author

Use python 3.10 for systems before 10.9 which does not have complete C++11 support (which is what everyone and ChatGPT says). If this version is wrong let me know.

@jmroot
Copy link
Member

jmroot commented Jan 27, 2025

We don't really want to be stuck using 3.10 on the older systems either. It would be better to solve the bootstrap problem.

@kencu
Copy link
Contributor

kencu commented Jan 27, 2025

we looked at this a few months ago too -- it's to be noted that libomp is actually not a build or run dep for any clang version, it's just been added for "convenience" basically, to facilitate OMP use.

So I believe it could be removed from the clang builds, basically, and the libomp dep added later on in some as-yet-not-created libomp portgroup perhaps or managed in some other way, rather than making it a runtime clang dep.

@eborisch
Copy link
Member

It looks like there is a compiler.openmp_version (in portconfigure.tcl) already that can be set to enforce a libomp dependency when needed.

I'm fine with removing libomp as a dependency of clang.

It could also be built as part of clang -- the downsides being that multiple versions of libomp (one per clang) would be installed (minor issue), but also any program that relies on libomp would then need to have clang installed as a runtime dependency (likely a larger issue).

@eborisch eborisch merged commit 57dae16 into macports:master Jan 30, 2025
3 checks passed
@i0ntempest i0ntempest deleted the libomp branch January 31, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

5 participants