py-findpython: new port #27690
py-findpython: new port #27690
Conversation
dgilman
force-pushed
the
findpython
branch
2 times, most recently
from
10eb598 to
8ef825d
Compare
python/py-findpython/Portfile
Outdated
| # borrowed from https://trac.macports.org/ticket/72050 | ||
| if {${name} ne ${subport}} { | ||
| if {${python.version} eq 39} { | ||
| build.args --skip-dependency-check |
There was a problem hiding this comment.
I was hitting the same dependency issue with pdm as seen in that ticket. You can also see it in the GH actions logs for the first commits I pushed to this PR, e.g. https://github.com/macports/macports-ports/actions/runs/13361861384/job/37312763006
It is only on python 3.9. I would drop 3.9 as a subport but poetry still will want it.
There was a problem hiding this comment.
looks like you're missing a dependency on py-packaging. Not sure where the message about missing pdm-backend and importlib-metadata originate from but just skipping the dependency check doesn't seem like a good idea....
There was a problem hiding this comment.
Take a look at the GH action output under "Installing dependencies for py39-findpython", you can see it is installing py-packaging. I was able to reproduce this locally too, where I could confirm that py39-packaging was installed but it would still fail with that error.
There was a problem hiding this comment.
you are not declaring a dependency on py-packaging, so it can't/shouldn't be installing that. I am not sure what the pdm backend is doing with the pdm.lock file - perhaps it's getting dependencies from there. But either way, this isn't correct.
There was a problem hiding this comment.
i'll do a push with suggested fixes and we'll see if it fails
Description
New dependency for poetry
Type(s)
Tested on
macOS 14.6.1 23G93 x86_64
Xcode 16.2 16C5032a
Verification
Have you
port lint?sudo port test?sudo port -vst install?