-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcdf: update to 4.9.3 (retry) #27710
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b9c5def
netcdf: update to 4.9.3
remkos 2a14eb4
netcdf: update to 4.9.3
remkos 81faf59
Merge branch 'remkos-netcdf' of https://github.com/remkos/macports-po…
remkos a1e85a3
netcdf: update to 4.9.3
remkos 72c83a7
netcdf: update to 4.9.3
remkos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
Remove check for install lib directory $libpath, because it does not exist yet | ||
--- ni/src/ncl/MakeNcl.csh.orig 2019-02-28 00:44:39 | ||
+++ ni/src/ncl/MakeNcl.csh 2025-02-19 14:06:58 | ||
@@ -28,11 +28,6 @@ | ||
set libmath = "-lngmath" | ||
set ncarg_libs = "$libncl $libnfp $libhlu $libncarg $libgks $libncarg_c $libmath" | ||
|
||
-if (! -d "$libpath") then | ||
- echo "Library directory <$libpath> does not exist." | ||
- exit 1 | ||
-endif | ||
- | ||
set files = "" | ||
set extra_opts = "" | ||
|
41 changes: 41 additions & 0 deletions
41
science/ncarg/files/patch-ni-src-ncl-remove-nc-set-log.diff
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
Remove nc_set_log_level() because it is not (no longer?) available in libnetcdf | ||
--- ni/src/ncl/NclNetCDF4.c.orig 2019-02-28 00:44:39 | ||
+++ ni/src/ncl/NclNetCDF4.c 2025-02-19 14:07:33 | ||
@@ -409,7 +409,6 @@ | ||
} | ||
|
||
/*nc_set_log_level(3);*/ | ||
- nc_set_log_level(3); | ||
|
||
ChunkSizeHint = 2 * blksize; | ||
|
||
--- ni/src/ncl/NclNetCdf.c.orig 2019-02-28 00:44:39 | ||
+++ ni/src/ncl/NclNetCdf.c 2025-02-19 14:07:38 | ||
@@ -614,7 +614,6 @@ | ||
} | ||
|
||
/*nc_set_log_level(3);*/ | ||
- nc_set_log_level(3); | ||
|
||
ChunkSizeHint = 64 * blksize; | ||
therec = (NetCdfFileRecord*)NclCalloc(1, sizeof(NetCdfFileRecord)); | ||
--- ni/src/ncl/NclNewHDF5.c.orig 2019-02-28 00:44:39 | ||
+++ ni/src/ncl/NclNewHDF5.c 2025-02-19 14:08:16 | ||
@@ -3834,7 +3834,6 @@ | ||
} | ||
|
||
/*nc_set_log_level(3);*/ | ||
- nc_set_log_level(3); | ||
|
||
grpnode = (NclFileGrpNode *)NclCalloc(1, sizeof(NclFileGrpNode)); | ||
assert(grpnode); | ||
--- ni/src/ncl/NclNewHDFEOS5.c.orig 2019-02-28 00:44:39 | ||
+++ ni/src/ncl/NclNewHDFEOS5.c 2025-02-19 14:08:21 | ||
@@ -530,7 +530,6 @@ | ||
} | ||
|
||
/*nc_set_log_level(3);*/ | ||
- nc_set_log_level(3); | ||
|
||
grpnode = (NclFileGrpNode *)NclCalloc(1, sizeof(NclFileGrpNode)); | ||
assert(grpnode); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
Replace '+' with '|' in sed. With '+' it complains about wrong flag | ||
--- ni/src/ncl/yMakefile.orig 2019-02-28 00:44:39 | ||
+++ ni/src/ncl/yMakefile 2025-02-19 14:06:24 | ||
@@ -655,12 +655,12 @@ | ||
|
||
MakeNcl: MakeNcl.csh Makefile | ||
@sed \ | ||
- -e 's+SED_CC_LD+$(CC_LD)+' \ | ||
- -e 's+SED_CC_OPT+$(CCOPTIONS)+' \ | ||
- -e 's+SED_LDLIBS+$(LDLIBS)+' \ | ||
- -e 's+SED_EXTRA_LDLIBS+$(EXTRA_LDLIBS)+' \ | ||
- -e 's+SED_LIBPATH+$(LIBPATH)+' \ | ||
- -e 's+SED_INCPATH+$(INCPATH)+' \ | ||
+ -e 's|SED_CC_LD|$(CC_LD)|' \ | ||
+ -e 's|SED_CC_OPT|$(CCOPTIONS)|' \ | ||
+ -e 's|SED_LDLIBS|$(LDLIBS)|' \ | ||
+ -e 's|SED_EXTRA_LDLIBS|$(EXTRA_LDLIBS)|' \ | ||
+ -e 's|SED_LIBPATH|$(LIBPATH)|' \ | ||
+ -e 's|SED_INCPATH|$(INCPATH)|' \ | ||
<MakeNcl.csh > MakeNcl | ||
|
||
#if defined(Darwin) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remkos I do not understand what you mean. It should work on macOS < 14, unless somebody has broken that.
Update. Okay, that is probably supposed to mean that on 14+ it started working after the fix and not that after the fix it only works on 14+, but the phrasing is confusing, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @barracuda156, that was the intent of the comment. It was meant to say that on macos-14 and later it only works with the fix to the g95 package in place. Older MacOS versions already worked without the fix.
I agree that the language was a bit confusing. It probably should have said:
For this to build on macos-14 or later, a recent fix to g95 is required: https://trac.macports.org/ticket/71068