Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s3cmd: update to 2.4.0; depend on Python 3.12; maintainer info changed #27800

Closed
wants to merge 0 commits into from
Closed

s3cmd: update to 2.4.0; depend on Python 3.12; maintainer info changed #27800

wants to merge 0 commits into from

Conversation

przmv
Copy link
Contributor

@przmv przmv commented Mar 2, 2025

Description

  • update to 2.4.0
  • depend on Python 3.12
  • maintainer info changed
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 13.7.3 22H417 x86_64
Command Line Tools 14.3.1.0.1.1683849156

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

reneeotten
reneeotten requested changes Mar 2, 2025
View reviewed changes
net/s3cmd/Portfile Outdated

python.default_version 38
python.default_version 312
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be using Python 3.13 as that's MacPorts' default since January 1st.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no Python 3.13 support for py-magic, so I opened additional PR #27805

@przmv przmv force-pushed the s3cmd-2.4.0 branch 2 times, most recently from 8447966 to 34910f6 Compare March 3, 2025 10:22
@przmv przmv closed this Mar 3, 2025
@przmv
Copy link
Contributor Author

przmv commented Mar 3, 2025

I somehow managed to screw this PR, so I opened a new one instead: #27807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten requested changes

Assignees
No one assigned
Labels
maintainer: none type: enhancement type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przmv @reneeotten @macportsbot