Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgis3: add hdf5 as dependency #27804

Merged
merged 1 commit into from
Mar 5, 2025
Merged

qgis3: add hdf5 as dependency #27804

merged 1 commit into from
Mar 5, 2025

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Mar 3, 2025 •
edited
Loading

Description

hdf5 is opportunistically linked if found, so better add it as a dependency. Also make sure to find path to 'mpi.h' if needed.

Closes: https://trac.macports.org/ticket/72100

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Veence for port qgis3.

@macportsbot macportsbot added maintainer maintainer: open Affects an openmaintainer port labels Mar 3, 2025
reneeotten
reneeotten requested changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@reneeotten reneeotten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since you're making changes to depends_lib you have to increase the revision

@nilason
qgis3: add hdf5 as dependency
3954cc3 
hdf5 is opportunistically linked if found. Also make sure
to find path to 'mpi.h'  if needed.

Closes: https://trac.macports.org/ticket/72100
@nilason
Copy link
Contributor Author

nilason commented Mar 4, 2025

since you're making changes to depends_lib you have to increase the revision

How could I forget?! Now fixed.

@reneeotten reneeotten merged commit bb6ae6a into macports:master Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten approved these changes

Assignees

@Veence Veence

Labels
maintainer: open Affects an openmaintainer port maintainer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nilason @macportsbot @reneeotten @Veence