Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to [email protected] #27842

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Conversation

lukaso
Copy link
Contributor

@lukaso lukaso commented Mar 8, 2025

Description

Update py-gobject3.

I've attempted to switch to meson build, but there's very little documentation out there to
suggest if this is the right way to do it.

It has worked for me, however.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.3.1 24D70 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port py-gobject3.
@dbevans for port py-gobject3.

@lukaso
Copy link
Contributor Author

lukaso commented Mar 8, 2025

It looks like the code for python < 38 isn't right anymore, but I wouldn't know how to fix it.

Also, my main test is being able to build gexiv2 afterwards, because that fails if py-gobject3 hasn't installed in the correct place, which was the case for many iterations that I tried.

@mascguy
Copy link
Member

mascguy commented Mar 8, 2025

It looks like the code for python < 38 isn't right anymore, but I wouldn't know how to fix it.

Also, my main test is being able to build gexiv2 afterwards, because that fails if py-gobject3 hasn't installed in the correct place, which was the case for many iterations that I tried.

I'll pull your changes, and take a look locally. More to follow.

@mascguy mascguy force-pushed the update-py-gobject3 branch from c7fef8a to cdab645 Compare March 8, 2025 15:08
@mascguy mascguy force-pushed the update-py-gobject3 branch from cdab645 to 0aed632 Compare March 8, 2025 15:11
@mascguy mascguy force-pushed the update-py-gobject3 branch from 0aed632 to 51b1145 Compare March 8, 2025 15:42
@mascguy
Copy link
Member

mascguy commented Mar 8, 2025

While the build for py36 is failing (as expected on the latest macOS releases like our CI runners), everything else looks good.

@mascguy mascguy merged commit fc6adff into macports:master Mar 8, 2025
1 of 3 checks passed
@lukaso
Copy link
Contributor Author

lukaso commented Mar 8, 2025

Great. Thanks. Had a feeling there was a more idiomatic way of doing the meson build!

@lukaso lukaso deleted the update-py-gobject3 branch March 8, 2025 15:49
@mascguy
Copy link
Member

mascguy commented Mar 8, 2025

Great. Thanks. Had a feeling there was a more idiomatic way of doing the meson build!

Always glad to help. And thank you for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants