Repository navigation
fix(organizations): enforce active membership on async member reads - #743
Draft
aldoruizluna wants to merge 1 commit into
Draft
aldoruizluna wants to merge 1 commit into
aldoruizluna wants to merge 1 commit into
Conversation
Use mounted AsyncSession contracts, serialize persisted membership fields, and exclude inactive memberships from organization reads. Keep profile data and platform bypass out of tenant rosters. Co-Authored-By: Codex <noreply@openai.com> Session: codex://threads/01a10513-8bed-7b40-92e8-5eac783dca16 (cherry picked from commit b21d81a)
Contributor
|
📚 Documentation checks found issues. Please review the maintenance script output. |
Contributor
|
|
Contributor
Security Scan SummaryDate: Wed Oct 21 01:24:28 UTC 2026 Scan Results
|
Contributor
🎭 Playwright E2E Test Results
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Cherry-pick (
-x, unchanged) ofb21d81a2(fix(organizations): enforce active membership on async member reads) onto currentmain:AsyncSessioncontracts and serialize persisted membership fields, so they are no longer served from the Redis-cachedself.db.querypath.list_organizations, which now requiresstatus == "active".apps/api/tests/unit/services/test_organization_member_reads.py.History
The commit was pushed on 2026-10-03 (its commit date) by an earlier agent session on
fix/member-read-api-2026-10-03, which never had a PR of its own. That branch's first three commits shipped through #687 and #691; this is the remaining one. Opened as a draft on a fresh branch during the 2026-10-21 wrap-up.Merge status
Based on current
main; the pick applied cleanly. One hunk (an import reorder inorganizations/dependencies.py) was already onmainand dropped out. Every touched file exceptorganizations/core.pyis byte-identical to the original commit;core.pydiffers only by later, unrelated changes onmain(#718).Review needed
Code review of the access-control change: active-membership filtering on every member/organization read, and how it interacts with #718's creator-membership and invitation changes. Merging ships the API through the normal release path.
🤖 Generated with Claude Code