depend on dataclasses package only for python<3.7 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this PR? If possible, we'd like to eliminate this dependency for our installation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of python3.7 dataclasses is built in to python
dataclasses package even changed their supported versions after 0.6 to
>=3.6, <3.7That means if we keep the dataclasses requirement we are stuck using dataclasses<=0.6 and don't use the built-in
Adding the suffix here will make sure we can use the built-in dataclasses
Currently we still get the requirement from
more_properties, which is why I also opened PR to change it there:madman-bob/python-more-properties#1