-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle invalid tessdata folder #559
base: master
Are you sure you want to change the base?
Conversation
Shouldn't we gracefully handle this in pytesseract instead and keep a variant of these tests? Just removing them does not feel right. The handling should probably depend on the Tesseract version as well. |
I must admit I'm not using |
I am not ok with removing invalid path testing. |
for more information, see https://pre-commit.ci
I've tried my best, to make it work and gracefully handle errors. I must admit it isn't perfect but its about as far as my limited pytest and pytesseracte knowledge gets me. |
Thank you for trying. Unfortunately it alters some of the current behavior and if Tesseract is not installed it will not say it. |
e5d07eb
to
deff509
Compare
7fc814d
to
6e4f31c
Compare
The newest tesseract version returns an error and exits when encountering invalid
tessdata-dir
. This makes these tests fail. The only tests that would still work would be to settessdata-dir
to a new empty folder, but that would mean making and then deleting that folder, for what I think is negligible benefit.