Skip to content

Conversation

fe80
Copy link

@fe80 fe80 commented Apr 3, 2025

Summary

This feature add the support of PodDisruptionBudget

Tests

cc:

@wangxiaoyou1993 wangxiaoyou1993 requested a review from Copilot May 9, 2025 04:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for Kubernetes PodDisruptionBudget (PDB) in the Helm chart configuration for both the webServer and scheduler components.

  • Adds new configuration entries in values.yaml for PDB options.
  • Introduces two new template files (pdb.yaml and pdb-scheduler.yaml) to generate PDB resources based on the new configuration.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
charts/mageai/values.yaml Adds PDB configuration options for webServer and scheduler
charts/mageai/templates/pdb.yaml New template to create a PDB for the webServer component based on values.yaml
charts/mageai/templates/pdb-scheduler.yaml New template to create a PDB for the scheduler component based on values.yaml
Comments suppressed due to low confidence (1)

charts/mageai/templates/pdb.yaml:10

  • [nitpick] Consider using nindent for the minAvailable and maxUnavailable keys to ensure consistent and proper YAML indentation in the generated manifest.
   {{- if .Values.webServer.PodDisruptionBudget.minAvailable }}

@wangxiaoyou1993
Copy link
Member

Did you test your change?

@fe80
Copy link
Author

fe80 commented Aug 27, 2025

I had missed the .Values.standaloneScheduler part, I just fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants