This repository was archived by the owner on Apr 29, 2019. It is now read-only.
Upgrade phpunit to 7.X #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- PHPUnit -> ~7.0.0 - PHPCPD -> ~4.0.0
buskamuza
suggested changes
Apr 14, 2018
| /** | ||
| * Class MethodInvokedAtIndex | ||
| * Matches invocations per 'method' at 'position' | ||
| * Example: | ||
| * Example:§ |
There was a problem hiding this comment.
Is paragraph symbol expected here?
|
Thanks for submitting the PR! |
- Replace \PHPUnit_Framework_MockObject_Matcher_InvokedCount - Replace \PHPUnit_Framework_MockObject_Stub_Return
Replaced hardcoded broken assertion
mikeymike
force-pushed
the
upgrade-phpunit
branch
from
b6f0b75 to
fd14539
Compare
|
@buskamuza thanks for the review, I'll take a look at the failing tests |
|
@buskamuza I'm not really sure why the last run is failing, potentially some edge case of some kind... would probably pass if rerun 🤔 Anyway I just read on slack that PHPUnit upgrade has already been completed by someone else so I guess this might have been a waste of time... I'll leave it for you to handle as needed 👍 |
slavvka
reviewed
Jun 29, 2018
| { | ||
| /** | ||
| * @var array | ||
| */ | ||
| protected $indexes = []; | ||
|
|
||
| /**PHPUnit_Framework_MockObject_Matcher_InvokedAtIndex |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade PHPUnit to 7
Currently only resolved failing unit tests and I'm fully expecting functional / integration tests to have some issues too but thought I'd start with this and check the tests in Travis
Fixed Issues (if relevant)
magento-engcom/zf1-php-7.2-support#6
Manual testing scenarios
phpunit -c dev/tests/unit/phpunit.xml.distContribution checklist