This repository was archived by the owner on Jun 19, 2018. It is now read-only.
Update to README to use env.phase #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to create my own version of Venia to get more familiar with these tools) ``` BuildpackValidationError: ServiceWorkerPlugin: Invalid configuration object. ServiceWorkerPlugin was called with a configuration object that has the following problems: - env.phase must be of type string ``` So I've changed the README to instruct devs to use `env.phase` rather than `env.mode`. Seems to be the same as the [ServiceWorkerPlugin README](https://github.com/magento-research/pwa-buildpack/blob/master/docs/ServiceWorkerPlugin.md) advises... > env.phase: String (Required) Must be either 'development' or 'production'.
|
Thanks @rossmc, and apologies for not getting to this PR sooner. We just moved all the contents of this repository and others to our new monorepo. We'll make sure to address these updates in the new repo. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across the bellow error after following the README while attempting to create my own version of Venia to get more familiar with these tools.
So I've changed the README to instruct devs to use
env.phaserather thanenv.mode. Seems to be the same as what the ServiceWorkerPlugin README advises...