-
Notifications
You must be signed in to change notification settings - Fork 152
Add Storefront properties for Product Attributes #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prabhuram93
wants to merge
3
commits into
magento:master
Choose a base branch
from
prabhuram93:patch-14
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
design-documents/graph-ql/coverage/eav/EavGraphQl.graphqls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Copyright © Magento, Inc. All rights reserved. | ||
# See COPYING.txt for license details. | ||
|
||
type Query { | ||
customAttributeMetadata(attributes: [AttributeInput!]!): CustomAttributeMetadata @resolver(class: "Magento\\EavGraphQl\\Model\\Resolver\\CustomAttributeMetadata") @doc(description: "The customAttributeMetadata query returns the attribute type, given an attribute code and entity type") @cache(cacheable: false) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is good but please change the location of your file to this file |
||
} | ||
|
||
type CustomAttributeMetadata @doc(description: "CustomAttributeMetadata defines an array of attribute_codes and entity_types") { | ||
items: [Attribute] @doc(description: "An array of attributes") | ||
} | ||
|
||
type Attribute @doc(description: "Attribute contains the attribute_type of the specified attribute_code and entity_type") { | ||
attribute_code: String @doc(description: "The unique identifier for an attribute code. This value should be in lowercase letters without spaces.") | ||
entity_type: String @doc(description: "The type of entity that defines the attribute") | ||
attribute_type: String @doc(description: "The data type of the attribute") | ||
input_type: String @doc(description: "The frontend input type of the attribute") | ||
attribute_options: [AttributeOption] @resolver(class: "Magento\\EavGraphQl\\Model\\Resolver\\AttributeOptions") @doc(description: "Attribute options list.") | ||
storefront_properties: StorefrontProperties | ||
} | ||
|
||
type StorefrontProperties { | ||
use_in_product_listing: Boolean | ||
position: Int | ||
visible_on_catalog_pages: Boolean | ||
use_in_layered_navigation: UseInLayeredNavigationOptions | ||
use_in_search_results_layered_navigation: Boolean | ||
} | ||
|
||
enum UseInLayeredNavigationOptions { | ||
NO | ||
FILTERABLE_WITH_RESULTS | ||
FILTERABLE_NO_RESULT | ||
} | ||
|
||
type AttributeOption @doc(description: "Attribute option.") { | ||
label: String @doc(description: "Attribute option label.") | ||
value: String @doc(description: "Attribute option value.") | ||
} | ||
|
||
input AttributeInput @doc(description: "AttributeInput specifies the attribute_code and entity_type to search") { | ||
attribute_code: String @doc(description: "The unique identifier for an attribute code. This value should be in lowercase letters without spaces.") | ||
entity_type: String @doc(description: "The type of entity that defines the attribute") | ||
} | ||
|
||
# Additional changes made in CatalogGraphQl schema | ||
type Aggregation @doc(description: "A bucket that contains information for each filterable option (such as price, category `UID`, and custom attributes).") { | ||
position: Int @doc(description: "The position of attribute in layered navigation block.") | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.