Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigurableWishlistItem.child_sku throws an internal error if customer wishlist has un-configured configurable product #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ConfigurableWishlistItem.child_sku throws an internal error if customer wishlist has un-configured configurable product #506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions design-documents/graph-ql/coverage/customer/Wishlist.graphqls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
type Mutation {
createWishlist(input: CreateWishlistInput!): CreateWishlistOutput # Multiple wishlists Commerce functionality
deleteWishlist(wishlistUid: ID!): DeleteWishlistOutput # Commerce fucntionality - in Opens Source we assume customer always has one wishlist
addProductsToWishlist(wishlistId: ID!, wishlistItems: [WishlistItemInput!]!): AddProductsToWishlistOutput
addProductsToWishlist(wishlistId: ID!, wishlistItems: [WishlistItemInput!]!): AddProductsToWishlistOutput
removeProductsFromWishlist(wishlistId: ID!, wishlistItemsIds: [ID!]!): RemoveProductsFromWishlistOutput
updateProductsInWishlist(wishlistId: ID!, wishlistItems: [WishlistItemUpdateInput!]!): UpdateProductsInWishlistOutput
copyProductsBetweenWishlists(sourceWishlistUid: ID!, destinationWishlistUid: ID!, wishlistItems: [WishlistItemCopyInput!]!): CopyProductsBetweenWishlistsOutput @doc(description: "Copy a product to the wish list")
Expand All @@ -14,7 +14,7 @@ type Mutation {
}

type Customer {
wishlist: Wishlist! @deprecated(reason: "Use `Customer.wishlists` or `Customer.wishlist_v2")
wishlist: Wishlist! @deprecated(reason: "Use `Customer.wishlists` or `Customer.wishlist_v2")
wishlist_v2(id: ID!): Wishlist # This query will be added in the ce
wishlists: [Wishlist!]! @doc(description: "Customer wishlists are limited to a max of 1 wishlist in Magento Open Source") # This query will be added in the ce
}
Expand Down Expand Up @@ -117,8 +117,9 @@ type VirtualWishlistItem implements WishlistItemInterface @doc(description: "Vir
}

type ConfigurableWishlistItem implements WishlistItemInterface {
child_sku: String! @doc(description: "SKU of the simple product corresponding to a set of selected configurable options.")
configurable_options: [SelectedConfigurableOption!]
child_sku: String! @deprecated(reason: "Use `ConfigurableWishlistItem.configured_variant.sku` instead.") @doc(description: "The SKU of the simple product corresponding to a set of selected configurable options.")
configurable_options: [SelectedConfigurableOption!] @doc(description: "An array of selected configurable options.")
configured_variant: ProductInterface @doc(description: "Product details of the selected variant. The value is null if some options are not configured.")
}

type DownloadableWishlistItem implements WishlistItemInterface @doc(description: "Downloadable Wishlist Item") {
Expand Down