Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GH2917 - Add note on accepted PRs in code and metadata for template #2918

Merged
merged 12 commits into from
Sep 14, 2018

Conversation

lorikrell
Copy link

@lorikrell lorikrell commented Sep 11, 2018

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will...

Add a note to the code contributing guide regarding accepted pull requests for 2.2/2.3.
Add a metadata section to the basic template, including the new group for toc.

Additional information

Resolves #2917

whatsnew
Added announcements and supported pull requests for v2.1, v2.2, and v2.3 Contributing guide. Updated the basic template for DevDocs contributions.

@lorikrell lorikrell added 2.x Major Update Significant original updates to existing content labels Sep 11, 2018
@lorikrell lorikrell self-assigned this Sep 11, 2018
@lorikrell lorikrell requested a review from dshevtsov September 11, 2018 22:40
@lorikrell
Copy link
Author

@dshevtsov If you want to verify the metadata for the basic template.
Community is reviewing the other note in contributing.md.


Parameter | Description
--- | ---
`group:` | The table of contents this file belongs to. Only add the name of the file without the extension. For example, the group of this file is `group: contributor-guide`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add path to the directory with toc files: _data/toc
And extend the example:
the group of this file is group: contributor-guide, it points to the table of contents defined in _data/toc/contributor-guide.yml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with the additions. I didn't add this to the tutorial template as it uses different group functions for that toc.

@@ -12,6 +12,23 @@ The purpose of this page is to provide you with a pre-formatted template and use

You can start off by editing the local version of this file using markdown language (and {% glossarytooltip a2aff425-07dd-4bd6-9671-29b7edefa871 %}HTML{% endglossarytooltip %} where needed). Then, create a Pull Request to have your contribution reviewed by the DevDocs team.

## Metadata parameters

Add the following {% glossarytooltip 3f0f2ef1-ad38-41c6-bd1e-390daaa71d76 %}metadata{% endglossarytooltip %} parameters at the top of your page. We use this data when generating the DevDocs for the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see metadata in the Glossary
Remove glossarytooltip

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Also removed it from the tutorial first page file (new in changed files for this PR).

`title:` | The title of the page.
`functional_areas:` | Optional. Adds facets for search results. Available facets include: sales, products, carts, customers, marketing, account, content, reports, stores, system, catalog, orders, frontend, theme, staging, search, configurations, integration, services, tools, setup, testing or test, standards, install, upgrade, B2B, cloud, and bundled extensions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The facets are case sensitive.
Update the list with the exact capitalization as defined in our internal wiki list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that info, and verified all entries match the list.

@@ -14,12 +14,14 @@ You can start off by editing the local version of this file using markdown langu

## Metadata parameters

Add the following {% glossarytooltip 3f0f2ef1-ad38-41c6-bd1e-390daaa71d76 %}metadata{% endglossarytooltip %} parameters at the top of your page. We use this data when generating the DevDocs for the following:
Add the following metadata parameters at the top of your page. We use this data when generating the DevDocs for the following:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add that we use YAML for the metadata in front matter.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added note to the opening text.

@lorikrell
Copy link
Author

Adding new notes for engcom. Targeting merge for Monday Sept 17th.

@lorikrell
Copy link
Author

Gathering feedback from EngCom for any further changes from their side. Target for publication Sept 17th.

Copy link
Contributor

@shrielenee shrielenee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things. I didn't scrape through every page but reviewed the end of code contributions specifically.

@lorikrell lorikrell changed the title Add note on accepted PRs in code and metadata for template GH2917 - Add note on accepted PRs in code and metadata for template Sep 14, 2018
@lorikrell lorikrell merged commit c621ac4 into master Sep 14, 2018
@lorikrell lorikrell deleted the lk-gh2917-contributor-guide branch September 14, 2018 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.x Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution guide updates
4 participants