-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Area for Customizable Options shows line break html<br/> on the front end in cart area if a user enters more than 55 characters #32977
Comments
Hi @adamstapley. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me 2.4-develop instance - upcoming 2.4.x release |
Hi @adamstapley. Thank you for your request. I'm working on Magento instance for you. |
Hi @adamstapley, here is your Magento Instance: https://b8f5c5bbfe16193694e9c15ef90cc1d9-2-4-develop.instances.magento-community.engineering |
Created a test product and issue still exist. This is a bundle product |
This looks like it might be related to issue #25418 I created a fix in Magento 2.4.2: Line 52 escapeHtml($_formatedOptionValue['full_view']) ?>Change to escapeHtml($_formatedOptionValue['full_view'], ['span', 'a']) ?>All line break code is removed. I presume this isn't the 100% correct way to achieve this but it works for me at the moment and I'm not a developer :) |
Hi @engcom-Alfa. Thank you for working on this issue.
|
Reproduced on 2.4.x. |
Hi @Den4ik. Thank you for working on this issue.
|
@magento I am working on this |
✅ Confirmed by @engcom-Alfa Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @adamstapley. Thank you for your report.
The fix will be available with the upcoming 2.4.3 release. |
Summary of the issue
We have Customizable Options with text areas where people can enter up to 350 characters. If they enter a message that's 50 characters with line breaks it all works OK and displays properly in the cart area. If they enter more than 55 characters the cart area displays the html
line break code
Preconditions (*)
Information on your environment
Running Magento 2.4.2
Dedicated server
PHP 7.3
MariaDB10.3
Steps to reproduce (*)
Steps to reproduce
Create a product in admin, create two customizable options both with text area option with 350 characters allowed. Enter less than 55 characters in one text area and more than 55 in the other both with spaces and line breaks. Add the item to your cart and you will see the html line breaks in the text area option with more than 55 characters.
Expected result (*)
Cart should just show the text entered in each option and not the html line break code
Actual result (*)
Cart shows html in option

The text was updated successfully, but these errors were encountered: