32977 Fixed text area for Customizable Options on the Checkout Cart Page

[AZiniukhin]

Description (*)

I created a solution in the file ( Magento/Checkout/view/frontend/templates/cart/item/default.phtml ).
For the correct display of the text, need to add one or more AllowedTags ( ['span', 'a'] ) to the function call
( $block->escapeHtml($_formatedOptionValue['full_view'], ['span', 'a'] ) by analogy with
( $block->escapeHtml($_formatedOptionValue['value'], ['span', 'a']) ).
If this is not done, then the formation of the text will take place without the pregmach function called on line 117 of the file
( lib/internal/Magento/Framework/Escaper.php ) which leads to incorrect display of text.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Text Area for Customizable Options shows line break html<br/> on the front end in cart area if a user enters more than 55 characters #32977

Manual testing scenarios (*)

1. Create a simple product in the admin panel.
2. Create two customizable options both with text area option with 350 characters allowed.
3. On the product page enter less than 55 characters in one text area and more than 55 in the other both with spaces and line breaks.

4. Add the item to your cart and go to the cart page. You will see the correct text display.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @AZiniukhin. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[AZiniukhin]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

Could you cover your fix with some kind of automated test?

[AZiniukhin]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento run Unit Tests, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[AZiniukhin]

The test added, please check @ihor-sviziev

[Den4ik]

@AZiniukhin Thanks for contribution.
Please look at my comment. What do you think?

[Den4ik]

I believe that heredoc syntax looks more clear

[Den4ik]

I believe that heredoc syntax looks more clear

[AZiniukhin]

@Den4ik
I added heredoc syntax. Please check.

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

✅ Approved
Changes looks good for me. @AZiniukhin Thanks for contribution.

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Create a product created with 2 customizable options. The options should be with text areas that accepts minimum 350 characters.

Manual testing scenario:

1. Front end - Checkout the same product with both the text area customizable options filled. (Note: Text area options should be filled with new line as well; Ex is in below screenshot)
   

2. Proceed to Checkout page and validate the product content.

Before: ✖️ <br /> text was getting appeared in the page

After: ✔️ One line description about the is the outcome after fix

The above scenario fulfills the testing coverage, and there is no additional regression is require to process with as there in no impact.

[m2-assistant]

Hi @AZiniukhin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.