Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CartItemOptionsProcessor to Magento_Quote's API #30819

Open
wants to merge 3 commits into
base: 2.5-develop
Choose a base branch
from

Conversation

navarr
Copy link
Member

@navarr navarr commented Nov 6, 2020

Description (*)

This class is used by at least one VBE and is necessary for loading Cart Item Options for quotes that are not "active" (for example, when wanting to retrieve option information for an order that has already been placed)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Add CartItemOptionsProcessor to Magento_Quote's API #30831: Add CartItemOptionsProcessor to Magento_Quote's API

This class is used by at least one VBE and is necessary for loading Cart Item Options for quotes that are not "active"
@m2-assistant
Copy link

m2-assistant bot commented Nov 6, 2020

Hi @navarr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

This class's public methods have been unchanged since Magento 2.1
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 6, 2020
@sidolov
Copy link
Contributor

sidolov commented Nov 6, 2020

@magento create issue

@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 14, 2021

I think you can change this PR branch to 2.5-develop branch
CC @sivaschenko @gabrieldagama consider this can be mark as API

@navarr
Copy link
Member Author

navarr commented Feb 15, 2021

@mrtuvn This PR backdates the @api annotation all the way to Magento 2.1.0; so I don't think the branch matters that much

@sivaschenko sivaschenko added this to the 2.5 milestone Feb 15, 2021
@sivaschenko
Copy link
Member

@navarr thanks for the PR! I think @mrtuvn is right, we wouldn't like to introduce new marked API to patch releases so this PR should be targeted to 2.5-develop. Also, since annotation is not needed, it should be set automatically during the release process for new API.

@navarr navarr changed the base branch from 2.4-develop to 2.5-develop February 15, 2021 15:18
@navarr
Copy link
Member Author

navarr commented Feb 15, 2021

@sivaschenko Updated.

@sivaschenko
Copy link
Member

@navarr thank you!

@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Priority: P3 May be fixed according to the position in the backlog. labels Feb 15, 2021
@sivaschenko
Copy link
Member

Approved in scope of magento/architecture#473, priority increased to P1

@sivaschenko
Copy link
Member

@magento run Static Tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-8764 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Quote Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.5 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. tech-partners-contribution Technology Partner: Vertex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Add CartItemOptionsProcessor to Magento_Quote's API
6 participants