Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34084: Replaced tag 'br' to a valid version #34136

Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Analytics/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<label>Advanced Reporting</label>
<comment><![CDATA[This service provides a dynamic suite of reports with rich insights about your business.
Your reports can be accessed securely on a personalized dashboard outside of the admin panel by clicking on the
"Go to Advanced Reporting" link. </br> For more information, see our <a target="_blank" href="https://magento.com/legal/terms/cloud-terms">
"Go to Advanced Reporting" link. <br/> For more information, see our <a target="_blank" href="https://magento.com/legal/terms/cloud-terms">
terms and conditions</a>.]]></comment>
<field id="enabled" translate="label" type="select" sortOrder="10" showInDefault="1">
<label>Advanced Reporting Service</label>
Expand Down Expand Up @@ -46,7 +46,7 @@
<field id="additional_comment" translate="label comment" type="label" sortOrder="40" showInDefault="1">
<label><![CDATA[<strong>Get more insights from Magento Business Intelligence</strong>]]></label>
<comment><![CDATA[Magento Business Intelligence provides you with a simple and clear path to
becoming more data driven.</br> Learn more about <a target="_blank"
becoming more data driven.<br/> Learn more about <a target="_blank"
href="https://dashboard.rjmetrics.com/v2/magento/signup/">Magento BI Essentials and BI Pro</a> tiers.]]></comment>
<frontend_model>Magento\Analytics\Block\Adminhtml\System\Config\AdditionalComment</frontend_model>
</field>
Expand Down
8 changes: 4 additions & 4 deletions app/code/Magento/Analytics/i18n/en_US.csv
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,20 @@ Configuration,Configuration
"BI Essentials","BI Essentials"
"This service provides a dynamic suite of reports with rich insights about your business.
Your reports can be accessed securely on a personalized dashboard outside of the admin panel by clicking on the
""Go to Advanced Reporting"" link. </br> For more information, see our
""Go to Advanced Reporting"" link. <br /> For more information, see our
<a href=""https://magento.com/legal/terms/privacy"">terms and conditions</a>.
","This service provides a dynamic suite of reports with rich insights about your business.
Your reports can be accessed securely on a personalized dashboard outside of the admin panel by clicking on the
""Go to Advanced Reporting"" link. </br> For more information, see our
""Go to Advanced Reporting"" link. <br /> For more information, see our
<a href=""https://magento.com/legal/terms/privacy"">terms and conditions</a>."
"Advanced Reporting Service","Advanced Reporting Service"
Industry,Industry
"Time of day to send data","Time of day to send data"
"<strong>Get more insights from Magento Business Intelligence</strong>","<strong>Get more insights from Magento Business Intelligence</strong>"
"Magento Business Intelligence provides you with a simple and clear path to
becoming more data driven.</br> Learn more about <a target=""_blank""
becoming more data driven.<br /> Learn more about <a target=""_blank""
href=""https://dashboard.rjmetrics.com/v2/magento/signup/"">BI Essentials</a> tier.","Magento Business Intelligence provides you with a simple and clear path to
becoming more data driven.</br> Learn more about <a target=""_blank""
becoming more data driven.<br /> Learn more about <a target=""_blank""
href=""https://dashboard.rjmetrics.com/v2/magento/signup/"">BI Essentials</a> tier."
"Auto Parts","Auto Parts"
"Baby/Children’s Apparel, Gear and Toys","Baby/Children’s Apparel, Gear and Toys"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
</div>
<div class="messages">
<div class="message message-warning">
<?= $block->escapeHtml(__('Please enter the password to confirm rollback.')) ?><br>
<?= $block->escapeHtml(__('Please enter the password to confirm rollback.')) ?><br />
<?= $block->escapeHtml(__('This action cannot be undone.')) ?>
<p><?= $block->escapeHtml(__('Are you sure you want to continue?')) ?></p>
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Captcha/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
<field id="symbols" translate="label comment" type="text" sortOrder="8" showInDefault="1" canRestore="1">
<label>Symbols Used in CAPTCHA</label>
<comment>
<![CDATA[Please use only letters (a-z or A-Z) or numbers (0-9) in this field. No spaces or other characters are allowed.<br />Similar looking characters (e.g. "i", "l", "1") decrease chance of correct recognition by customer.]]>
<![CDATA[Please use only letters (a-z or A-Z) or numbers (0-9) in this field. No spaces or other characters are allowed.<br/>Similar looking characters (e.g. "i", "l", "1") decrease chance of correct recognition by customer.]]>
</comment>
<depends>
<field id="enable">1</field>
Expand Down Expand Up @@ -134,7 +134,7 @@
<field id="symbols" translate="label comment" type="text" sortOrder="8" showInDefault="1" showInWebsite="1" canRestore="1">
<label>Symbols Used in CAPTCHA</label>
<comment>
<![CDATA[Please use only letters (a-z or A-Z) or numbers (0-9) in this field. No spaces or other characters are allowed.<br />Similar looking characters (e.g. "i", "l", "1") decrease chance of correct recognition by customer.]]>
<![CDATA[Please use only letters (a-z or A-Z) or numbers (0-9) in this field. No spaces or other characters are allowed.<br/>Similar looking characters (e.g. "i", "l", "1") decrease chance of correct recognition by customer.]]>
</comment>
<depends>
<field id="enable">1</field>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
class="fieldset admin__fieldset <?= $block->getIsLastFieldset() ? 'last-fieldset' : '' ?>">
<legend class="legend admin__legend">
<span><?= $block->escapeHtml(__('Custom Options')) ?></span>
</legend><br>
</legend><br />
<?php foreach ($options as $option) :?>
<?= $block->getOptionHtml($option) ?>
<?php endforeach;?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<legend class="legend">
<span><?= $block->escapeHtml(__('Add Product To Websites')) ?></span>
</legend>
<br>
<br />
<div class="store-scope">
<div class="store-tree" id="add-products-to-website-content">
<?php foreach ($block->getWebsiteCollection() as $_website):?>
Expand Down Expand Up @@ -56,7 +56,7 @@
<legend class="legend">
<span><?= $block->escapeHtml(__('Remove Product From Websites')) ?></span>
</legend>
<br>
<br />
<div class="messages">
<div class="message message-notice">
<div><?= $block->escapeHtml(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
?>
<fieldset id="grop_fields" class="fieldset">
<legend class="legend"><span><?= $block->escapeHtml(__('Product In Websites')) ?></span></legend>
<br>
<br />
<?php if ($block->getProductId()):?>
<div class="messages">
<div class="message message-notice">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<?php endif; ?>
<fieldset class="fieldset form-inline">
<legend class="legend"><span><?= $block->escapeHtml(__('Advanced Inventory')) ?></span></legend>
<br>
<br />
<div id="table_cataloginventory">
<div class="field">
<label class="label" for="inventory_manage_stock">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<fieldset id="<?= $block->escapeHtmlAttr($_jsObjectName) ?>" <?= /* @noEscape */ $_element->serialize(['class']) ?>
class="fieldset">
<legend class="legend"><span><?= $block->escapeHtml($_element->getLegend()) ?></span></legend>
<br>
<br/>
<?php if ($_element->getComment()): ?>
<div class="messages">
<div class="message message-notice"><?= $block->escapeHtml($_element->getComment()) ?></div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function execute()

$errors = $fileUploader->validate();
if (true !== $errors) {
$errorMessage = implode('</br>', $errors);
$errorMessage = implode('<br/>', $errors);
$result = $this->processError(($errorMessage));
} else {
$result = $fileUploader->upload();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function execute()

$errors = $fileUploader->validate();
if (true !== $errors) {
$errorMessage = implode('</br>', $errors);
$errorMessage = implode('<br />', $errors);
throw new LocalizedException(__($errorMessage));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public function testExecuteWithErrors()
$resultJson->expects($this->once())
->method('setData')
->with([
'error' => implode('</br>', $errors),
'error' => implode('<br />', $errors),
'errorcode' => 0,
])
->willReturnSelf();
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/Customer/etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
<field id="email_no_password_template" translate="label comment" type="select" sortOrder="75" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Default Welcome Email Without Password</label>
<comment><![CDATA[
This email will be sent instead of the Default Welcome Email, if a customer was created without password. <br /><br />
This email will be sent instead of the Default Welcome Email, if a customer was created without password. <br/><br/>
Email template chosen based on theme fallback when "Default" option is selected.
]]></comment>
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>
Expand All @@ -119,7 +119,7 @@
<field id="email_confirmed_template" translate="label comment" type="select" sortOrder="110" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Welcome Email</label>
<comment><![CDATA[
This email will be sent instead of the Default Welcome Email, after account confirmation. <br /><br />
This email will be sent instead of the Default Welcome Email, after account confirmation. <br/><br/>
Email template chosen based on theme fallback when "Default" option is selected.
]]></comment>
<source_model>Magento\Config\Model\Config\Source\Email\Template</source_model>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
</strong>
<div class="box-content">
<p>
<?= $block->escapeHtml($block->getName()) ?><br>
<?= $block->escapeHtml($block->getCustomer()->getEmail()) ?><br>
<?= $block->escapeHtml($block->getName()) ?><br/>
<?= $block->escapeHtml($block->getCustomer()->getEmail()) ?><br/>
</p>
<?= $block->getChildHtml('customer.account.dashboard.info.extra'); ?>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ $viewModel = $block->getViewModel();
enctype="multipart/form-data"
data-hasrequired="<?= $escaper->escapeHtmlAttr(__('* Required Fields')) ?>">
<fieldset class="fieldset">
<legend class="legend"><span><?= $escaper->escapeHtml(__('Contact Information')) ?></span></legend><br>
<legend class="legend"><span><?= $escaper->escapeHtml(__('Contact Information')) ?></span></legend><br />
<?= $block->getBlockHtml('formkey') ?>
<input type="hidden" name="success_url" value="<?= $escaper->escapeUrl($block->getSuccessUrl()) ?>">
<input type="hidden" name="error_url" value="<?= $escaper->escapeUrl($block->getErrorUrl()) ?>">
Expand All @@ -54,7 +54,7 @@ $viewModel = $block->getViewModel();

</fieldset>
<fieldset class="fieldset">
<legend class="legend"><span><?= $escaper->escapeHtml(__('Address')) ?></span></legend><br>
<legend class="legend"><span><?= $escaper->escapeHtml(__('Address')) ?></span></legend><br />
<div class="field street required">
<label for="street_1" class="label"><span><?= /* @noEscape */ $_street ?></span></label>
<div class="control">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use Magento\Customer\Block\Widget\Name;
autocomplete="off">
<fieldset class="fieldset info">
<?= $block->getBlockHtml('formkey') ?>
<legend class="legend"><span><?= $block->escapeHtml(__('Account Information')) ?></span></legend><br>
<legend class="legend"><span><?= $block->escapeHtml(__('Account Information')) ?></span></legend><br />
<?= $block->getLayout()->createBlock(Name::class)->setObject($block->getCustomer())->toHtml() ?>

<?php $_dob = $block->getLayout()->createBlock(\Magento\Customer\Block\Widget\Dob::class) ?>
Expand Down Expand Up @@ -53,7 +53,7 @@ use Magento\Customer\Block\Widget\Name;
<fieldset class="fieldset password" data-container="change-email-password">
<legend class="legend">
<span data-title="change-email-password"><?= $block->escapeHtml(__('Change Email and Password')) ?></span>
</legend><br>
</legend><br />
<div class="field email required" data-container="change-email">
<label class="label" for="email"><span><?= $block->escapeHtml(__('Email')) ?></span></label>
<div class="control">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<form class="form form-newsletter-manage" action="<?= $block->escapeUrl($block->getAction()) ?>" method="post" id="form-validate">
<fieldset class="fieldset">
<?= $block->getBlockHtml('formkey') ?>
<legend class="legend"><span><?= $block->escapeHtml(__('Subscription option')) ?></span></legend><br>
<legend class="legend"><span><?= $block->escapeHtml(__('Subscription option')) ?></span></legend><br />
<div class="field choice">
<input type="checkbox" name="is_subscribed" id="subscription" value="1" title="<?= $block->escapeHtmlAttr(__('General Subscription')) ?>"<?php if ($block->getIsSubscribed()) : ?> checked="checked"<?php endif; ?> class="checkbox">
<label for="subscription" class="label"><span><?= $block->escapeHtml(__('General Subscription')) ?></span></label>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ $formData = $block->getFormData();
autocomplete="off">
<?= /* @noEscape */ $block->getBlockHtml('formkey') ?>
<fieldset class="fieldset create info">
<legend class="legend"><span><?= $escaper->escapeHtml(__('Personal Information')) ?></span></legend><br>
<legend class="legend"><span><?= $escaper->escapeHtml(__('Personal Information')) ?></span></legend><br />
<input type="hidden" name="success_url" value="<?= $escaper->escapeUrl($block->getSuccessUrl()) ?>">
<input type="hidden" name="error_url" value="<?= $escaper->escapeUrl($block->getErrorUrl()) ?>">
<?= $block->getLayout()
Expand Down Expand Up @@ -74,7 +74,7 @@ $formData = $block->getFormData();
<?php $postcodeValidationClass = $addressHelper->getAttributeValidationClass('postcode'); ?>
<?php $regionValidationClass = $addressHelper->getAttributeValidationClass('region'); ?>
<fieldset class="fieldset address">
<legend class="legend"><span><?= $escaper->escapeHtml(__('Address Information')) ?></span></legend><br>
<legend class="legend"><span><?= $escaper->escapeHtml(__('Address Information')) ?></span></legend><br />
<input type="hidden" name="create_address" value="1" />

<?php $_company = $block->getLayout()->createBlock(\Magento\Customer\Block\Widget\Company::class) ?>
Expand Down Expand Up @@ -224,7 +224,7 @@ $formData = $block->getFormData();
<?php endif; ?>
<fieldset class="fieldset create account"
data-hasrequired="<?= $escaper->escapeHtmlAttr(__('* Required Fields')) ?>">
<legend class="legend"><span><?= $escaper->escapeHtml(__('Sign-in Information')) ?></span></legend><br>
<legend class="legend"><span><?= $escaper->escapeHtml(__('Sign-in Information')) ?></span></legend><br />
<div class="field required">
<label for="email_address" class="label"><span><?= $escaper->escapeHtml(__('Email')) ?></span></label>
<div class="control">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<?php $_links = $block->getLinks(); ?>
<?php $_linksLength = 0; ?>
<?php $_isRequired = $block->getLinkSelectionRequired(); ?>
<legend class="legend links-title"><span><?= $block->escapeHtml($block->getLinksTitle()) ?></span></legend><br>
<legend class="legend links-title"><span><?= $block->escapeHtml($block->getLinksTitle()) ?></span></legend><br/>
<div class="field downloads<?php if ($_isRequired) { echo ' required'; } ?><?php if (!$_linksPurchasedSeparately) { echo ' downloads-no-separately'; } ?>">
<label class="label"><span><?= $block->escapeHtml($block->getLinksTitle()) ?></span></label>
<div class="control" id="downloadable-links-list"
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Eav/Model/Attribute/Data/Multiline.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public function outputValue($format = \Magento\Eav\Model\AttributeDataFactory::O
$output = $values;
break;
case \Magento\Eav\Model\AttributeDataFactory::OUTPUT_FORMAT_HTML:
$output = implode("<br />", $values);
$output = implode("<br/>", $values);
break;
case \Magento\Eav\Model\AttributeDataFactory::OUTPUT_FORMAT_ONELINE:
$output = implode(" ", $values);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use Magento\Framework\App\TemplateTypesInterface;
<form action="<?= $block->escapeUrl($block->getLoadUrl()) ?>" method="post" id="email_template_load_form">
<?= $block->getBlockHtml('formkey') ?>
<fieldset class="admin__fieldset form-inline">
<legend class="admin__legend"><span><?= $block->escapeHtml(__('Load Default Template')) ?></span></legend><br>
<legend class="admin__legend"><span><?= $block->escapeHtml(__('Load Default Template')) ?></span></legend><br />
<div class="admin__field required">
<label class="admin__field-label" for="template_select">
<span><?= $block->escapeHtml(__('Template')) ?></span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,11 @@ protected function _prepareForm()
$this->escapeHtml(
'For Type "Local Server" use relative path to &lt;Magento root directory&gt;/'
.$this->imagesDirectoryProvider->getDirectoryRelativePath()
.', e.g. <i>product_images</i>, <i>import_images/batch1</i>.<br><br>'
.', e.g. <i>product_images</i>, <i>import_images/batch1</i>.<br /><br />'
.'For example, in case <i>product_images</i>, files should be placed into '
.'<i>&lt;Magento root directory&gt;/'
.$this->imagesDirectoryProvider->getDirectoryRelativePath() . '/product_images</i> folder.<br>'
.'<br>If remote storage is enabled, in case <i>product_images</i>, files should be placed into '
.$this->imagesDirectoryProvider->getDirectoryRelativePath() . '/product_images</i> folder.<br />'
.'<br />If remote storage is enabled, in case <i>product_images</i>, files should be placed into '
.'<i>&lt;Remote Storage&gt;/'
.$this->imagesDirectoryProvider->getDirectoryRelativePath() . '/product_images</i> folder.',
['i', 'br']
Expand Down
Loading