_beforeToHtml DocBlock return type $this instead of string

[lucafuser]

Description (*)

Changed _beforeToHtml DocBlock return type $this instead of string In Magento/Checkout/Block/Onepage/Success.php according to Magento/Framework/View/Element/AbstractBlock.php parent class.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] _beforeToHtml DocBlock return type $this instead of string #39508: _beforeToHtml DocBlock return type $this instead of string

[m2-assistant]

Hi @lucafuser. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[lucafuser]

@magento run all tests

[engcom-Hotel]

@magento create issue

[lucafuser]

Hello @lucafuser,

Thanks for the contribution!

The changes looks good to me, but please fix the failed tests.

Thanks

Hi @engcom-Hotel
Fixed

[engcom-Charlie]

Manual testing is not required here, as this PR is only updating the doc block. Since the build is failing, moving it to Extended Testing.

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests EE, Semantic Version Checker

[engcom-Charlie]

@magento run Functional Tests B2B, Functional Tests EE, Semantic Version Checker

[engcom-Charlie]

One of the Functional B2B tests is not consistent in recent 2 builds. The other failing test is a known issue. The failure is neither related to PR nor part of this PR.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39490/da75aa17bebfd33d3e4a8819e21c0bd1/Functional/allure-report-b2b/index.html#categories/6387c2c831bf17728851420d6ec7c25f/a1d47e4643d8ed20/

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39490/5acf263fefab082f9d6e7f3c5534e2ed/Functional/allure-report-b2b/index.html#categories

The Functional EE test failure is neither related to PR nor part of this PR. Its a known issue.

Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39490/bf375520530b55f6a56127991824d9f1/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39490/bcfe2b8278fc78bd670d8d2c0c424989/Functional/allure-report-ee/index.html#categories

Known Issue:
ACQE-7460: CheckingOfPreviewingRegistryUpdateEmailTest

[engcom-Charlie]

Raised internal approval JIRA for the SVC failure. Moving this PR to Pending Approval now. We will proceed ahead on this once will get all the required approvals.

SVC: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39490/9b0b0512bb3de58ccfdfcc261b94a225/SemanticVersionChecker/report-magento2.html